Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email icons and update svgIconTemplate converter #81

Merged
merged 8 commits into from
Jun 10, 2022

Conversation

PetroSilenius
Copy link
Contributor

  • Add three new icons Note, Write and MailSend
  • Refactor svg icon convert tempalte to use svgr/cli v6, switch to typescript

Couldn't figure out how to make the template add types for props so currently those have to be added manually😔

@PetroSilenius PetroSilenius marked this pull request as ready for review June 9, 2022 12:16
@PetroSilenius PetroSilenius requested a review from a team as a code owner June 9, 2022 12:17
Copy link
Contributor

@kacperkosinski kacperkosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

templateSvgIcon.ts Outdated Show resolved Hide resolved
@kacperkosinski
Copy link
Contributor

kacperkosinski commented Jun 9, 2022

@PetroSilenius Hey, actually maybe we can improve it event a bit more.
We can create npm script in package.json:

"generate-icon": "npx @svgr/cli --typescript --template templateSvgIcon.ts -d src/icons --ext tsx $npm_config_path"

And run it like this: npm run generate-icon --path=path/to/file.svg

@PetroSilenius
Copy link
Contributor Author

@PetroSilenius Hey, actually maybe we can improve it event a bit more.
We can create npm script in package.json:

"generate-icon": "npx @svgr/cli --template templateSvgIcon.ts -d src/icons --ext tsx $npm_config_path"

And run it like this: npm run generate-icon --path=path/to/file.svg

Sure at that point we could also install @svgr/cli as a devdepency to avoid installing it through npx. I can do those changes here👍🏻

@PetroSilenius PetroSilenius merged commit a8a499c into lyytioy:next Jun 10, 2022
@PetroSilenius PetroSilenius deleted the add-email-icons branch June 10, 2022 12:55
@PetroSilenius PetroSilenius mentioned this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants